PWA first commit #404
Merged
PWA first commit #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log('New content is available; please refresh.') | ||
| let confirmationResult = confirm('New content found! Do you want to reload the app?') | ||
| if (confirmationResult) { registration.waiting.postMessage({ action: 'skipWaiting' }) } |
There was a problem hiding this comment.
I prefer 'if' blocks to be on a separate line unless it's really short (like the return on line 37 below, which is ok!).
In fact, I think you'll get a lint error because your have the { } block on the same line as the if.
| @@ -29,4 +31,11 @@ if (process.env.NODE_ENV === 'production') { | |||
| console.error('Error during service worker registration:', error) | |||
| } | |||
| }) | |||
|
|
|||
| let refreshing | |||
There was a problem hiding this comment.
You should probably initialize this to false.
| workbox.precaching.suppressWarnings() | ||
| workbox.precaching.precacheAndRoute(self.__precacheManifest, {}) | ||
|
|
||
| // install new service worker when ok, then reload page. |
There was a problem hiding this comment.
See the comment I wrote in https://github.com/severinbeauvais/lear/blob/1225/coops-ui/src/service-worker.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#1225
Description of changes:
Created custom service worker
Updated the register service worker to show the confirmation pop up and post the message to the service worker. Added call back to force reload the window once user confirms to update the app.
Updated the vue config to point to custom service worker
Note : This commit is to test whether the confirmation popup is displayed when a new version of the app is available. May need a few iterations to get this working
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).