Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX][LUCY-188] - Fix to Admin, allow access to INSPECT Web #1162

Merged
merged 5 commits into from
Jan 12, 2024
Merged

[FIX][LUCY-188] - Fix to Admin, allow access to INSPECT Web #1162

merged 5 commits into from
Jan 12, 2024

Conversation

davidclaveau
Copy link
Contributor

Pull Request Standards

  • The title of the PR is accurate
  • The title includes the type of change [HOTFIX, FEATURE, etc]
  • The PR title includes the ticket number in format of [LUCY-###]
  • Documentation is updated to reflect change

Description

This PR includes the following proposed change(s):

  • Update to allow hot-reloading in local
    • Update to compile frontend on every change
    • Required an update to Node in the Dockerfile
  • Migrate LUCY Web to use Keycloak Gold
    • Add PKCE to Keycloak token request
    • Validate Keycloak JWT using PKCE setup
  • Update to LUCY Web's base url when working on local

@davidclaveau davidclaveau marked this pull request as ready for review January 12, 2024 19:39
LocalNewsTV
LocalNewsTV previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@LocalNewsTV LocalNewsTV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

app/lucy/src/app/services/sso.service.ts Outdated Show resolved Hide resolved
@davidclaveau @LocalNewsTV
Update app/lucy/src/app/services/sso.service.ts
3c39850 
Co-authored-by: Matthew Logan <62873746+LocalNewsTV@users.noreply.github.com>
@LocalNewsTV LocalNewsTV self-requested a review January 12, 2024 19:49
@davidclaveau davidclaveau merged commit 907efc6 into dev Jan 12, 2024
9 checks passed
@davidclaveau davidclaveau deleted the feature/fix-to-admin-frontend branch January 12, 2024 19:49
@davidclaveau davidclaveau mentioned this pull request Mar 7, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalNewsTV LocalNewsTV LocalNewsTV approved these changes

Assignees
No one assigned
Labels
Docker Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidclaveau @LocalNewsTV