Skip to content

Commit

Permalink
[MDS-6206] Add support for custom permit condition categories (#3318)
Browse files Browse the repository at this point in the history
* [MDS-6206] Added permit condition categories endpoints

* Added initial frontend support for managing permit condition categories

* MDS-6206 Create permit condition categories as is when importing

* MDS-6206 Added FE tests + bugfixes

* UX Tweaks, fix snapshot

* Updated download/upload artifact versions

* Fixed tests

* Revert css change

* Revert cypress change

* MDS-6206 Updated permit action creator tests

* MDS-6206Added more tests

* MDS-6206 Added cancel button to inline category selector + more tests

* Fixed tests

* Fix missing required indicator

* Fixed conditions text missing from terms and conditions

* Added keyDown listener

* Updated snapshot

* Fix report test flakiness

* MDS-6206 Fix flaky test

* Fix filter

* Updated after PR review
  • Loading branch information
simensma-fresh authored Nov 28, 2024
1 parent a05e67b commit 1070b97
Show file tree
Hide file tree
Showing 93 changed files with 3,682 additions and 696 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/core-web.cypress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
CYPRESS_FLAGSMITH_URL: https://mds-flags-dev.apps.silver.devops.gov.bc.ca/api/v1/
CYPRESS_FLAGSMITH_KEY: 4Eu9eEMDmWVEHKDaKoeWY7
- name: Upload cypress video
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-recording
Expand All @@ -81,7 +81,7 @@ jobs:
run: tar cvzf ./logs.tgz ./logs
- name: Upload logs to GitHub
if: failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: logs.tgz
path: ./logs.tgz
4 changes: 2 additions & 2 deletions .github/workflows/minespace.cypress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
CYPRESS_FLAGSMITH_URL: https://mds-flags-dev.apps.silver.devops.gov.bc.ca/api/v1/
CYPRESS_FLAGSMITH_KEY: 4Eu9eEMDmWVEHKDaKoeWY7
- name: Upload cypress video
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
if: failure()
with:
name: cypress-recording
Expand All @@ -81,7 +81,7 @@ jobs:
run: tar cvzf ./logs.tgz ./logs
- name: Upload logs to GitHub
if: failure()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: logs.tgz
path: ./logs.tgz
12 changes: 6 additions & 6 deletions .github/workflows/tests.coverage.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
./../../cc-test-reporter format-coverage -t coverage.py --add-prefix services/core-api/ -o ../../coverage/backend-codeclimate.json coverage.xml
- name: Create backend coverage file artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: backend-codeclimate.json
path: ./coverage/backend-codeclimate.json
Expand Down Expand Up @@ -112,7 +112,7 @@ jobs:
./../../cc-test-reporter format-coverage -t clover --add-prefix services/core-web/ -o ../../coverage/frontend-codeclimate.json clover.xml
- name: Create frontend coverage file artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: frontend-codeclimate.json
path: ./coverage/frontend-codeclimate.json
Expand Down Expand Up @@ -171,7 +171,7 @@ jobs:
./../../cc-test-reporter format-coverage -t clover --add-prefix services/minespace-web/ -o ../../coverage/minespace-codeclimate.json clover.xml
- name: Create minespace coverage file artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: minespace-codeclimate.json
path: ./coverage/minespace-codeclimate.json
Expand Down Expand Up @@ -211,17 +211,17 @@ jobs:
# Fetch artifacts from other jobs
- name: Download backend artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: backend-codeclimate.json
path: ./coverage
- name: Download frontend artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: frontend-codeclimate.json
path: ./coverage
- name: Download minespace artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: minespace-codeclimate.json
path: ./coverage
Expand Down
Loading

0 comments on commit 1070b97

Please sign in to comment.