Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5809] - Fix loading bug on new IRT/Update IRT Import Form #3068

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

matbusby-fw
Copy link
Collaborator

Objective

MDS-5809

The IRTFileImport component has been refactored to handle "createInformationRequirementsTable" and "updateInformationRequirementsTableByFile" within component-defined functions. Import changes include the addition of the IFileInfo interface and the FormWrapper component from the '@mds/common' library.
This update modifies the InformationRequirementsTablePage component to enhance its handling and fetching of data. Default values have been added for situations when 'location.state.current' is undefined. A new function, 'getRequirementsVersion', has been created to derive and assign the requirements version in a more effective manner.
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_minespace-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Apr 25, 2024
@matbusby-fw matbusby-fw merged commit 550328d into develop Apr 25, 2024
10 of 11 checks passed
@matbusby-fw matbusby-fw deleted the mds-5809-irt-updates branch April 25, 2024 16:14
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
* Refactor IRTFileImport component and update imports

The IRTFileImport component has been refactored to handle "createInformationRequirementsTable" and "updateInformationRequirementsTableByFile" within component-defined functions. Import changes include the addition of the IFileInfo interface and the FormWrapper component from the '@mds/common' library.

* Update InformationRequirementsTablePage component

This update modifies the InformationRequirementsTablePage component to enhance its handling and fetching of data. Default values have been added for situations when 'location.state.current' is undefined. A new function, 'getRequirementsVersion', has been created to derive and assign the requirements version in a more effective manner.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants