[MDS-5707] Added history view to Tailings Storage Facilities #3075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensma-fresh
requested review from
matbusby-fw,
henryoforeh-dev,
taraepp,
isuru-aot and
asinn134
|
|
|
|
matbusby-fw
reviewed
Apr 26, 2024
matbusby-fw
reviewed
Apr 26, 2024
matbusby-fw
approved these changes
Apr 26, 2024
simensma-fresh
commented
Apr 28, 2024
henryoforeh-dev
approved these changes
Apr 29, 2024
simensma-fresh
added a commit
that referenced
this pull request
Jun 12, 2024
* MDS-5708 Updated basic info page * [MDS-5707] Added history view of TSF * MDS-5707 Cleanup of tsf changes * MDS-5707 Cleanup * MDS-5707 Fixed broken tests * Updated TSP for core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5707
History View
Added a TSF History view to the basic info page in core/minespace.
SQLAlchemy Continuum
Introduced SQLAlchemy Continuum for "automatic" handling of version tracking. Basically, just add a
__versioned__ = {}property to your model and it'll create a Version model behind the scene that gets automatically added to on insert, updates, and deletes.Migrations
Added a utility command
make generate_version_table_migration TABLE=<table_name>that you can use to automatically generate a database migration for the_versiontable you want to create, and a DB migration to backfill existing data.