[MDS-5836] trigger notification report requested #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuru-aot
requested review from
taraepp,
simensma-fresh,
henryoforeh-dev,
matbusby-fw and
asinn134
henryoforeh-dev
previously approved these changes
May 8, 2024
matbusby-fw
reviewed
May 8, 2024
| permit_info_value = self.permit_number + ": " | ||
|
|
||
| subject = "A Report is requested in MineSpace" | ||
| due_date = due_date = (self.due_date).strftime("%b %d %Y") if self.due_date else "N/A" |
There was a problem hiding this comment.
Suggested change
| due_date = due_date = (self.due_date).strftime("%b %d %Y") if self.due_date else "N/A" | |
| due_date = (self.due_date).strftime("%b %d %Y") if self.due_date else "N/A" |
There was a problem hiding this comment.
@matbusby-fw need your approval again for this.
matbusby-fw
requested changes
May 8, 2024
|
asinn134
approved these changes
May 10, 2024
henryoforeh-dev
approved these changes
May 10, 2024
matbusby-fw
approved these changes
May 10, 2024
simensma-fresh
pushed a commit
that referenced
this pull request
Jun 12, 2024
* email notification for report requests * fixing permit view * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-5836
Why are you making this change? Provide a short explanation and/or screenshots
