Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5973] Setting up featureflag checks for project summary backend validation #3092

Merged
merged 2 commits into from
May 9, 2024

Conversation

asinn134
Copy link
Collaborator

@asinn134 asinn134 commented May 9, 2024

Objective

MDS-5973

  • Added condition to check for ams_agent feature flag to determine if we include validation on agent, applicant, facility, legal land, and authorization

Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@asinn134 asinn134 merged commit 0638a06 into develop May 9, 2024
11 of 12 checks passed
@asinn134 asinn134 deleted the mds-5802-backend-validation-with-featureflags branch May 9, 2024 22:27
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
…validation (#3092)

* setting up featureflag checks for project summary backend validation

* fixing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants