Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5947] Added ability to link a CRR to a HSRC code in core #3106

Merged
merged 3 commits into from
May 22, 2024

Conversation

simensma-fresh
Copy link
Collaborator

@simensma-fresh simensma-fresh commented May 21, 2024

Objective

MDS-5947

Added a new step to the HSRC editor allow you to link the code to a CRR that is not in use (or linked to an expired code)

image
image

image

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. labels May 22, 2024
from app.extensions import cache
from app.api.constants import STATIC_CONTENT_KEY

def reset_static_content_cache():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨🏻‍💻

@simensma-fresh simensma-fresh merged commit cb0f9fc into develop May 22, 2024
19 of 22 checks passed
@simensma-fresh simensma-fresh deleted the MDS-5947_CRR-fe branch May 22, 2024 17:45
simensma-fresh added a commit that referenced this pull request Jun 12, 2024
* MDS-5947 Added support for linking CRRs to code sections

* Updated snasphost

* MDS-5947 Fixed error when not including linked reports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 💻 Frontend This pull request includes frontend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants