Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5972] Update CORE homepage links #3126

Merged
merged 1 commit into from
May 28, 2024
Merged

[MDS-5972] Update CORE homepage links #3126

merged 1 commit into from
May 28, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented May 28, 2024

Objective

  • match new links in ticket
  • ticket had option of linking to the HSRC pdf or its webpage- went with the PDF because a) seems more consistent, and b) sometimes external links break
  • there wasn't yet a snapshot test for the CORE homepage so I made one

MDS-5972

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

matbusby-fw
matbusby-fw approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@taraepp taraepp merged commit 503c4d8 into develop May 28, 2024
12 checks passed
@taraepp taraepp deleted the mds-5972-doc-links-homepage branch May 28, 2024 16:39
simensma-fresh pushed a commit that referenced this pull request Jun 12, 2024
@taraepp @simensma-fresh
[MDS-5972] Update CORE homepage links (#3126)
e6b18ba 
update links, PDFs, and create a snap test for the HomePage which wasn't created before
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@simensma-fresh simensma-fresh Awaiting requested review from simensma-fresh

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

@asinn134 asinn134 Awaiting requested review from asinn134

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taraepp @henryoforeh-dev @matbusby-fw