Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-5935] UpdatedCore API dependencies and base python image (3.11.9-slim) #3132

Merged
merged 1 commit into from
May 30, 2024
Merged

[MDS-5935] UpdatedCore API dependencies and base python image (3.11.9-slim) #3132

merged 1 commit into from
May 30, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-5935

This PR upgrades the base python image used by the Core API to Python 3.11.9, and changes it to use the slim version.

  1. This makes the base image a whole lot smaller, and does not include a couple of packages with reported vulnerabilities. I've yet to find any dependencies requiring OS dependencies not included in the slim version.
  2. Updates Gunicorn, Pillow, and cryptography to fix a couple of reported vulnerabilities

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@simensma-fresh simensma-fresh added 🏭 CI/CD This pull request includes CI/CD changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. labels May 30, 2024
matbusby-fw
matbusby-fw approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@simensma-fresh simensma-fresh merged commit ea6ad29 into develop May 30, 2024
13 checks passed
@simensma-fresh simensma-fresh deleted the MDS-5935_Fix-core-vulnerabilities branch May 30, 2024 22:50
simensma-fresh added a commit that referenced this pull request Jun 12, 2024
@simensma-fresh
[MDS-5935] UpdatedCore API dependencies and base python image (3.11.9…
a36069c 
…-slim) (#3132)

MDS-5935 UpdatedCore API dependencies and base python image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinn134 asinn134 asinn134 approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@taraepp taraepp Awaiting requested review from taraepp

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. 🏭 CI/CD This pull request includes CI/CD changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simensma-fresh @henryoforeh-dev @matbusby-fw @asinn134