[MDS-6006] Allow ability to edit and remove the orgbook associations #3140
Conversation
isuru-aot
requested review from
matbusby-fw,
simensma-fresh,
henryoforeh-dev,
taraepp and
asinn134
|
|
||
| useEffect(() => { | ||
| if (selectedParty !== current_party) { | ||
| setSelectedParty(placeHolder); |
There was a problem hiding this comment.
Any particular reason for setting the selected party state to be the constant placeholder value "Start typing to search OrgBook..." ?
There was a problem hiding this comment.
In the flow,
- User sees the place holder (initial step, when no party is associated)
- Then user types and select one party and click on
Associatebutton. This is will disabled the search box - Then (if) user want to change the selected party, user clicks on
Disassociatebutton (screen shots in the PR) - In step (3), if assigned selected party as
- setSelectedParty(NONE) -> it will show None in the search box
- setSelectedParty("") -> it will show the empty in the search box.
So I thought assigning the place holder to the party, makes things easier for the user.
If there's better options to handle this, please let me know.
There was a problem hiding this comment.
@henryoforeh-dev actually, setSelectedParty(undefined) resolve the issue. I'll commit this
| raise NotFound('OrgBook entity not found.') | ||
|
|
||
| party_orgbook_entity.delete() | ||
| return None, 204 |
There was a problem hiding this comment.
-
The @api.marshal_with decorator specifies a status code of 201, which is used for "Created" responses. However, for a successful deletion, the status code should be 204 (No Content).
-
The @api.expect(parser) decorator suggests that some input validation or parsing is expected, but it is not being utilized within the function.
There was a problem hiding this comment.
This is addressed.
|
|
|
|
There was a problem hiding this comment.
Delete and remake makes sense to me in this case.
Only admins can see button and disassociate, good call! assuming Rebecca agrees.
I wonder if we should start showing the Party NAME and Orgbook names together (the original feature overrode the party name with the orgbook name). But that is future work.
…3140) * Allow ability to edit and remove the orgbook associations * Fixing the issue of missing the party after the update * Fixing the issue of changing the selected party before associating * Fixing the label when nothing is selected. * Updating roles for delete resource * Addressing PR comments * Addressing PR comments
Objective
MDS-6006
party_orgbook_entitytable.Why are you making this change? Provide a short explanation and/or screenshots
