Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5976] AMS Payment contact info #3146

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

henryoforeh-dev
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev commented Jun 11, 2024

Objective

MDS-5976

Why are you making this change? Provide a short explanation and/or screenshots

  • Created component to store payment contact information.
  • Added migration script to create new column in project summary table and type code for mine payment party.

image

}, []);

return (
<div className="ant-form-vertical" style={{ paddingTop: 12 }}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need the "ant-form-vertical" classname, the parent already has it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

</Col>
<Col md={12} sm={24}>
<Field
name="payment_contact.address[0].post_code"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering about the validation on these. This one looks like it wants the postalCodeWithCountry validation, and is the country not even required? I think it autosaves with Canada if sent through as null.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added validation. On the figma design, all the address fields are optional. I think it is also in line with what Ana asked for during our meeting with her. The main information they want are the ones that are mandatory.

Figma design screenshot.
https://www.figma.com/design/O7i6jpbKbju49HfL1OpozT/CORE-%26-Minespace-2021-2023?node-id=30995-90032&t=0utC7RRmtI5R9Cfj-0

image

matbusby-fw
matbusby-fw previously approved these changes Jun 12, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@henryoforeh-dev henryoforeh-dev merged commit d435509 into develop Jun 13, 2024
22 of 24 checks passed
@henryoforeh-dev henryoforeh-dev deleted the MDS-5976-ams-payment-contact-info branch June 13, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants