-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-5976] AMS Payment contact info #3146
Conversation
}, []); | ||
|
||
return ( | ||
<div className="ant-form-vertical" style={{ paddingTop: 12 }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't need the "ant-form-vertical" classname, the parent already has it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
</Col> | ||
<Col md={12} sm={24}> | ||
<Field | ||
name="payment_contact.address[0].post_code" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering about the validation on these. This one looks like it wants the postalCodeWithCountry
validation, and is the country not even required? I think it autosaves with Canada if sent through as null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added validation. On the figma design, all the address fields are optional. I think it is also in line with what Ana asked for during our meeting with her. The main information they want are the ones that are mandatory.
Figma design screenshot.
https://www.figma.com/design/O7i6jpbKbju49HfL1OpozT/CORE-%26-Minespace-2021-2023?node-id=30995-90032&t=0utC7RRmtI5R9Cfj-0
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'Failed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Objective
MDS-5976
Why are you making this change? Provide a short explanation and/or screenshots