Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5913] Adding new file uploaders to major projects authorization #3152

Merged

Conversation

asinn134
Copy link
Collaborator

@asinn134 asinn134 commented Jun 14, 2024

Objective

MDS-5913

  • In Core and Minespace Major project's Purpose and Authorizations section, added file uploaders for:

    1. Consent Letter
    2. Change of Ownership, Name or Address Form
    3. Clause Amendment Form
    4. Exemption Letter
    

-some uploaders are available depending on user input selection, so for example if user selects Modify Monitoring Requirements or Regulatory Change, Clause Amendment Form uploader will be available and required.

  • Adjusted front and back end to validate for the required files in Purpose and Authorization section. For this I ended up setting up fields (for example location_documents, etc) for each of the file uploaders to make the requirement check work, but also left the amendment_documents array for simplifying the upload process.

  • Moved the document uploader section within Purpose and Authorization out of the
    Pre-Application Exemption Request for Environmental Management Act application checkbox selection. Instead this checkbox now just determines if the exemption text banner, exemption reason text box, and exemption file uploader shows up.

  • Fixed a bug where uploading documents to multiple uploaders at the same time will only display in the document table the document that finished uploading last.

Screenshot (338)

Screenshot (340)

Screenshot (341)

matbusby-fw
matbusby-fw previously approved these changes Jun 14, 2024
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicd work!

Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@asinn134 asinn134 dismissed stale reviews from henryoforeh-dev and matbusby-fw via 3fd4674 June 18, 2024 18:33
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@asinn134 asinn134 requested a review from taraepp June 18, 2024 19:06
@asinn134 asinn134 merged commit cb81f8e into develop Jun 18, 2024
21 of 23 checks passed
@asinn134 asinn134 deleted the mds-5913-adding-file-uploaders-to-projects-authorization branch June 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants