-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-5913] Adding new file uploaders to major projects authorization #3152
[MDS-5913] Adding new file uploaders to major projects authorization #3152
Conversation
…TES, update references, remove restriction on CORE viewing/saving a draft, fix a style issue
…d up as props, make the forms have proper references. Use label props instead of hardcoding label text
…ct summary form on the CORE project summary page, make adjustments both there and on MS
services/common/src/components/projectSummary/AuthorizationsInvolved.tsx
Show resolved
Hide resolved
services/common/src/components/projectSummary/AuthorizationsInvolved.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicd work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
3fd4674
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'Failed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Objective
MDS-5913
In Core and Minespace Major project's Purpose and Authorizations section, added file uploaders for:
-some uploaders are available depending on user input selection, so for example if user selects
Modify Monitoring Requirements
orRegulatory Change
, Clause Amendment Form uploader will be available and required.Adjusted front and back end to validate for the required files in Purpose and Authorization section. For this I ended up setting up fields (for example location_documents, etc) for each of the file uploaders to make the requirement check work, but also left the amendment_documents array for simplifying the upload process.
Moved the document uploader section within Purpose and Authorization out of the
Pre-Application Exemption Request for Environmental Management Act application
checkbox selection. Instead this checkbox now just determines if the exemption text banner, exemption reason text box, and exemption file uploader shows up.Fixed a bug where uploading documents to multiple uploaders at the same time will only display in the document table the document that finished uploading last.