Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Fixed red underlines for cypress commands in VSCode #3156

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[FIX] Fixed red underlines for cypress commands in VSCode #3156

merged 1 commit into from
Jun 18, 2024

Conversation

simensma-fresh
Copy link
Collaborator

@simensma-fresh simensma-fresh commented Jun 17, 2024 •
edited
Loading

Objective

MDS-0000

Before:
image

After:
image

@simensma-fresh simensma-fresh added 🐞 Bug Something isn't working :( 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 🏭 CI/CD This pull request includes CI/CD changes. labels Jun 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

matbusby-fw
matbusby-fw approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

taraepp
taraepp approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@taraepp taraepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥹

henryoforeh-dev
henryoforeh-dev approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@simensma-fresh simensma-fresh merged commit 40059a9 into develop Jun 18, 2024
18 checks passed
@simensma-fresh simensma-fresh deleted the fix-cypress-setting branch June 18, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taraepp taraepp taraepp approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@henryoforeh-dev henryoforeh-dev henryoforeh-dev approved these changes

@isuru-aot isuru-aot Awaiting requested review from isuru-aot

@asinn134 asinn134 Awaiting requested review from asinn134

Assignees
No one assigned
Labels
🐞 Bug Something isn't working :( 🏭 CI/CD This pull request includes CI/CD changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@simensma-fresh @henryoforeh-dev @matbusby-fw @taraepp