Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-5946] AMS amendment #3161

Merged
merged 10 commits into from
Jun 20, 2024
Merged

[MDS-5946] AMS amendment #3161

merged 10 commits into from
Jun 20, 2024

Conversation

henryoforeh-dev
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev commented Jun 19, 2024

Objective

MDS-5946

Why are you making this change? Provide a short explanation and/or screenshots

  • Implement functionality to create AMS amendment.
  • Added / Updated unit tests.
  • Fixed potential bug in application summary.

matbusby-fw and others added 7 commits June 6, 2024 15:06
# Conflicts:
#	services/common/src/components/syncfusion/__snapshots__/AmazonS3Provider.spec.js.snap
#	services/core-api/app/api/projects/project_summary/models/project_summary.py
#	services/core-api/app/api/services/ams_api_service.py
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
4.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@henryoforeh-dev henryoforeh-dev merged commit c52d8f0 into develop Jun 20, 2024
21 of 23 checks passed
@henryoforeh-dev henryoforeh-dev deleted the mds-5946-ams-amendment branch June 20, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants