Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6064] Removed changing default cipher for NRIS download #3177

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-6064

DEFAULT_CIPHERS is no longer a property on .ssl_ causing the following error:
Tested out downloads locally without it and they work fine without any ssl related errors.

image

@simensma-fresh simensma-fresh added 🐞 Bug Something isn't working :( 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. labels Jul 8, 2024
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌈

@simensma-fresh simensma-fresh merged commit 43fbdc5 into develop Jul 8, 2024
11 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6064 branch July 8, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 🐞 Bug Something isn't working :( 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants