Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6067] Update VC Feature Flags #3186

Merged
merged 8 commits into from
Jul 19, 2024
Merged

[MDS-6067] Update VC Feature Flags #3186

merged 8 commits into from
Jul 19, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Jul 17, 2024

Objective

MDS-6067

New Flags:

vc_anoncreds_core - All VC Core Features, should used for development.
vc_anoncreds_minespace - All VC Minespace features, might be used to disable misbehaving features if needed.
vc_w3c - W3C Credential features, unused currently, and might only be used for UNTP credentials in OrgBook
vc_mines_act_permit_20 - There is a pending change to the values in the anoncred, this one is likely temporary.

Other various changes, logging and imports.

@Jsyro Jsyro marked this pull request as ready for review July 17, 2024 18:56
Copy link
Collaborator

@taraepp taraepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the unused imports on MinePermitTable.tsx are taken out I think we're good to go.

@Jsyro
Copy link
Collaborator Author

Jsyro commented Jul 19, 2024

@simensma-fresh

Who should make the co-responding changes in Flagsmith (knowing we need to keep the old ones until this change goes to all environments.

Copy link

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
27.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Jsyro Jsyro merged commit ce26615 into develop Jul 19, 2024
17 of 18 checks passed
@Jsyro Jsyro deleted the feature/vc-feature-flags branch July 19, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants