Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add in spatial bundle feature flag to FE #3187

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Jul 17, 2024

Objective

  • put spatial bundle behind feature flag
  • The way I did it will result in a minor UI difference from pre-feature flag
    • before adding the spatial features, there was a single document table with a "category" column to indicate spatial/supporting
    • I figured it wouldn't be a problem to keep the tables separate like they will be when the flag is turned on

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
69.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that should work!

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@taraepp taraepp merged commit 53f1458 into develop Jul 17, 2024
13 of 14 checks passed
@taraepp taraepp deleted the fix-spatial-docs-feature-flag branch July 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants