Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6042] Core Permit Details Page #3190

Merged
merged 17 commits into from
Jul 23, 2024
Merged

Conversation

matbusby-fw
Copy link
Collaborator

Objective

  • Created a new ViewPermits page
    • Created subcomponents for ViewPermitOverview, ViewPermitConditions and ViewPermitReports
  • updated some response models to return required information
  • Created a common CoreTag component for general use
  • Added some helper functions for displaying the description from various core-static-content sections

MDS-6042

image

@matbusby-fw matbusby-fw force-pushed the mds-6042-permit-details branch from df187ac to 7a174e8 Compare July 19, 2024 19:54
@matbusby-fw matbusby-fw added the 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. label Jul 19, 2024
taraepp
taraepp previously approved these changes Jul 19, 2024
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, clean job

@matbusby-fw matbusby-fw dismissed stale reviews from henryoforeh-dev and taraepp via 793b757 July 19, 2024 22:36
@matbusby-fw matbusby-fw force-pushed the mds-6042-permit-details branch from 793b757 to cd09488 Compare July 19, 2024 23:05
: record.permit?.permit_amendment_guid;
const menu = (
<Menu>
<Menu.Item key="0">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not add in the deprecated Menu.Item syntax where it's not pre-existing.
This should get changed out for the items syntax which is present in a few places in our codebase.

The useParams hook should be removed- I don't think that id is being used, but if it is it'll have to be passed down.

@taraepp
Copy link
Collaborator

taraepp commented Jul 22, 2024

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues 4 New issues 0 Accepted issues

Measures 0 Security Hotspots 80.2% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

some unused props to remove from this component. Would be nice to also resolve that cognitive complexity issue as well but it'll take more work to refactor.

const permitColumns = [...columns];

const partyRelationships = useSelector(getPartyRelationships);
Copy link
Collaborator

@taraepp taraepp Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I think happened:

  1. MinePermitTable was made, and used redux mapStateToProps to get partyRelationships from the state as a "prop". It was then added to propTypes
  2. Someone working on MinePermitInfo saw partyRelationships in the MinePermitTable propTypes and passed it as a prop
  3. Leading to it being both a prop and a redux state value

We could do either/or, really: take it out as a prop, or take out the useSelector redux value. I'd probably take it out as a prop because MinePermitInfo isn't otherwise using partyRelationships

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
28.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
76.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@henryoforeh-dev henryoforeh-dev merged commit d28a0f1 into develop Jul 23, 2024
16 of 18 checks passed
@henryoforeh-dev henryoforeh-dev deleted the mds-6042-permit-details branch July 23, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants