[MDS-6024] All Documents Tab #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new components in common
…es, fix TS issues, update tests
…over tab component on MS
asinn134
reviewed
Jul 26, 2024
| import { Loading as CommonLoading } from "@mds/common/components/common/Loading"; | ||
|
|
||
| const Loading = () => { | ||
| return <CommonLoading />; |
There was a problem hiding this comment.
nice to see load spinner be more consistent across minespace and core
simensma-fresh
previously approved these changes
Jul 26, 2024
| <div id={href}> | ||
| <Typography.Title level={titleLevel}> | ||
| <DeleteOutlined | ||
| // className="violet" |
There was a problem hiding this comment.
Can probably remove this
# Conflicts: # services/common/src/interfaces/projects/projectSummary.interface.ts
|
|
|
henryoforeh-dev
approved these changes
Jul 26, 2024
asinn134
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TO DO:
Minespace styling! Horizontal alignment in layout is bad (it overlaps, and also the content extends beyond the right page boundary)double check heading sizes, styling, spacing(it's not perfect but added Row/Col/gutter, Alert, and fixed heading sizes)would be nice if the random looking "top" values in stylesheet were at least composed of variables and didn't look completely arbitrary (& difficult to maintain if padding/margin changes)MDS-6024
Why are you making this change? Provide a short explanation and/or screenshots