-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6086] Fixed ssl validation error when running permit pipeline in test, enable https for elasticsearch when running locally #3210
Merged
simensma-fresh
merged 14 commits into
develop
from
MDS-6086_Permit-condition-extraction
Aug 12, 2024
Merged
[MDS-6086] Fixed ssl validation error when running permit pipeline in test, enable https for elasticsearch when running locally #3210
simensma-fresh
merged 14 commits into
develop
from
MDS-6086_Permit-condition-extraction
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Permit-condition-extraction
simensma-fresh
requested review from
henryoforeh-dev,
matbusby-fw,
taraepp and
asinn134
August 9, 2024 21:25
simensma-fresh
added
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
💾 Backend
This pull request includes backend changes.
labels
Aug 9, 2024
Quality Gate failed for 'bcgov-sonarcloud_mds_permits'Failed conditions |
henryoforeh-dev
approved these changes
Aug 9, 2024
matbusby-fw
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💾 Backend
This pull request includes backend changes.
👍 Ready for review
Pull request has been double checked by the author and is ready for comments and feedback.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6086
Fixed an error when running the permit extraction pipeline in test. Elasticsearch in dev/test are using a self signed certificate, requiring the caller to pass along a
ca
cert, that can be used for validation. Celery is not set up to handle that out of the box, so added support for it.Also changed elasticsearch locally to accept
https
connections for easier debugging - which is what the cert generation introduced is all about (inspired by this elasticsearch example )