Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6026] View Permit Conditions #3218

Merged
merged 21 commits into from
Aug 19, 2024
Merged

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Aug 15, 2024

Objective

  • flesh out the View Permit Conditions Page
    • it's scrolly now and has tab navigation
    • there's buttons added that were in the mockup, since we're behind a feature flag. Mostly they either do nothing or console log "not implemented" (please feel free to change my stubbed-in event handlers as necessary in future work!)
  • Some things that really increased the files changed count with single changes:
    • there is now a reusable header component. It wanted MS & CORE to have the same route name for MINE_DASHBOARD for GLOBAL_ROUTES. Updated all references.
    • I made a CORE button component with defined custom types. And so I made it a scss file and moved rules in there on CORE. And then I got rid of an extraneous classname. And then I got rid of the CORE/MS DocumentTable component and replaced with references to the common one.

MDS-6026

Why are you making this change? Provide a short explanation and/or screenshots
image

@taraepp taraepp force-pushed the mds-6026-view-permit-conditions branch from 74b3e4f to eec90ac Compare August 15, 2024 18:00
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_common'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
79.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@simensma-fresh
Copy link
Collaborator

So close!
image

@taraepp taraepp merged commit a0fff42 into develop Aug 19, 2024
14 of 15 checks passed
@taraepp taraepp deleted the mds-6026-view-permit-conditions branch August 19, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants