Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6165] - add object types to jsonld and reference untp context files #3241

Merged
merged 7 commits into from
Sep 13, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Sep 9, 2024

Objective

Objects must be typed for JSON-LD to link properly.

Corresponding changes in this repo, working on those actively as well https://github.com/Jsyro/untp-models

@Jsyro Jsyro changed the title [FIX] - add object types to jsonld and reference untp context files [MDS-6165] - add object types to jsonld and reference untp context files Sep 11, 2024
@Jsyro Jsyro marked this pull request as ready for review September 11, 2024 23:25
@Jsyro Jsyro added 🌶 Enhancement This is a new feature or request. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. labels Sep 12, 2024
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
18.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

matbusby-fw
matbusby-fw previously approved these changes Sep 12, 2024
@Jsyro Jsyro merged commit 7510526 into develop Sep 13, 2024
9 of 10 checks passed
@Jsyro Jsyro deleted the feature/untp-dcc-cleanup branch September 13, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💾 Backend This pull request includes backend changes. 🌶 Enhancement This is a new feature or request. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants