-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6129] streamline status actions #3245
Conversation
# Conflicts: # services/common/src/components/projectSummary/AuthorizationsInvolved.tsx
[SystemFlagEnum.core]: new Set(["DFT", "ASG", "UNR", "CHR", "OHD"]), | ||
}; | ||
|
||
if (disabledStatuses.has(projectSummaryStatusCode)) return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Don't see .has
used too much. Slick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. My only thought is that we should probably add some snapshots for these project components (I realize for the most part you just added the disabled functionality on most of them, but maybe we could bump up the coverage a bit by adding snapshots for at least a couple of them?)
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate failed for 'bcgov-sonarcloud_mds_common'Failed conditions |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'Issues Measures |
I added snapshot tests for all the components. While still short on recommended coverage, it will take more work to get each one to 80%. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Yeah, I think we're okay not always hitting the 80%. Especially in cases like this where it requires new testing on previously created work.
Objective
MDS-6129
Why are you making this change? Provide a short explanation and/or screenshots
Implemented logic to enable/disable fields with respect to status.
All conditions are in Miroboard link. https://miro.com/app/board/uXjVKnK62M0=/