Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6129] streamline status actions #3245

Merged
merged 11 commits into from
Sep 13, 2024

Conversation

henryoforeh-dev
Copy link
Contributor

@henryoforeh-dev henryoforeh-dev commented Sep 11, 2024

Objective

MDS-6129

Why are you making this change? Provide a short explanation and/or screenshots

Implemented logic to enable/disable fields with respect to status.

All conditions are in Miroboard link. https://miro.com/app/board/uXjVKnK62M0=/

[SystemFlagEnum.core]: new Set(["DFT", "ASG", "UNR", "CHR", "OHD"]),
};

if (disabledStatuses.has(projectSummaryStatusCode)) return true;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Don't see .has used too much. Slick.

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice. My only thought is that we should probably add some snapshots for these project components (I realize for the most part you just added the disabled functionality on most of them, but maybe we could bump up the coverage a bit by adding snapshots for at least a couple of them?)

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
64.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_core-api'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
16.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@henryoforeh-dev
Copy link
Contributor Author

Looks really nice. My only thought is that we should probably add some snapshots for these project components (I realize for the most part you just added the disabled functionality on most of them, but maybe we could bump up the coverage a bit by adding snapshots for at least a couple of them?)

I added snapshot tests for all the components. While still short on recommended coverage, it will take more work to get each one to 80%.

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Yeah, I think we're okay not always hitting the 80%. Especially in cases like this where it requires new testing on previously created work.

@henryoforeh-dev henryoforeh-dev merged commit 2ed8d13 into develop Sep 13, 2024
17 of 18 checks passed
@henryoforeh-dev henryoforeh-dev deleted the MDS-6129-streamline-status-actions branch September 13, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants