-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDS-6169] PRR records not showing in minespace #3256
Conversation
if (!permitGuid) { | ||
setCodeRequiredReports(mineReports); | ||
setCRRPageData(pageData); | ||
} else if (permitGuid) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super minor, but this could probably just be an else
@@ -0,0 +1,9 @@ | |||
import { IMineReport } from "../.."; | |||
|
|||
export interface IMineReportPageData { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check out core-web ReportsTable for IPageData<IMineReport>
! Generic type for the same thing, so we don't need to create as many interfaces
Quality Gate passed for 'bcgov-sonarcloud_mds_common'Issues Measures |
Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'Issues Measures |
Quality Gate passed for 'bcgov-sonarcloud_mds_core-web'Issues Measures |
Objective
MDS-6169
fetchMineReports
call and pagination to handle CRR and PRR records separately.(below are not part of original ticket)