Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDS-6118] Added failure state to permit extraction flow + fix error when conditions are not matching a category #3266

Merged
merged 5 commits into from
Oct 16, 2024
Merged

[MDS-6118] Added failure state to permit extraction flow + fix error when conditions are not matching a category #3266

merged 5 commits into from
Oct 16, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-6118

  1. Update permit conditions with the general category if no sections could be matched to one (the case for old permits). Without it, an error is produced
  2. Update the state of the extraction task stored in the core DB when an extraction task actually fails (for any reason)
  3. Added an error state if extraction failed

@simensma-fresh simensma-fresh added 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. labels Oct 16, 2024
matbusby-fw
matbusby-fw requested changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Just left one comment about using antD typography over p and h3.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_permits'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
71.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
57.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

matbusby-fw
matbusby-fw approved these changes Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦛

@simensma-fresh simensma-fresh merged commit 720689b into develop Oct 16, 2024
14 of 16 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6118_Fixes branch October 16, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asinn134 asinn134 asinn134 approved these changes

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@henryoforeh-dev henryoforeh-dev Awaiting requested review from henryoforeh-dev

@taraepp taraepp Awaiting requested review from taraepp

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simensma-fresh @matbusby-fw @asinn134