[MDS-6129] Clean-up in project summary and add react-redux typing #3293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
let i
loop to afor const
loop though.<a>
I took out wasn't linking anywhereisFieldDisabled
function is specific to projects but was in a generic utils file with a generic-sounding name (probably put in becauseremoveNullValuesRecursive
is there). But I also don't like that it's not specific to the field it's potentially disabling and therefore doesn't need to be called 88 times. Still deciding whether to just call it once (or max once per file) or turn it into a createSelector or memoize it.@ts-ignore
s are added is where our current typing isn't working outdispatch(args).then(func)
<Values = any>
- so it's generic but if you don't give it a type it defaults to any) but it wasn't working and it was way too complicated with redux-form, which initializes FormData as {}, which really interferes with typing (hence theas IProjectSummaryForm
instead offormValues: IProjectSummaryForm
)MDS-6129
Why are you making this change? Provide a short explanation and/or screenshots