[MDS-6129] project summary status: frontend #3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all them at top level and pass down as props. TODO: the auth/env ones aren't being called yet. Add disabling to fields that were missed, and correct instances of isDisabled where disabled was intended. TODO: declaration page, auth documents (clarify)
…iately. Fix bug with confirmation checkbox. Fix invalid status code in data mocks and add the enum to the interface. Add error handling in geomark
taraepp
force-pushed
the
mds-6129-project-summary-status
branch
from
033344e to
a112388
Compare
taraepp
commented
Nov 7, 2024
| @@ -28,9 +28,9 @@ describe("ProjectDates", () => { | |||
| <FormWrapper | |||
| name={FORM.ADD_EDIT_PROJECT_SUMMARY} | |||
| initialValues={MOCK.PERMITS} | |||
There was a problem hiding this comment.
Some of these, the form initialValues are very wacky.
taraepp
added
👍 Ready for review
matbusby-fw
reviewed
Nov 8, 2024
| message: `Failed to upload ${file && file.name ? file.name : ""}: ${ | ||
| errorMessage ? errorMessage : err | ||
| }`, | ||
| message: `Failed to upload ${file?.name ?? ""}: ${errorMessage ?? err |
There was a problem hiding this comment.
Super minor, but if the file.name is null would this not render as "Failed to upload : {errorMessage}". Noting the presence and placement of the colon.
matbusby-fw
reviewed
Nov 8, 2024
| ) => { | ||
| // Return false if status = "" => "Not Started" | ||
| if (!projectSummaryStatusCode) return false; | ||
| export const areFieldsDisabled = memoize((systemFlag: SystemFlagEnum, projectSummaryStatusCode: string) => { |
matbusby-fw
previously approved these changes
Nov 8, 2024
…ack to null, even though antd is unhappy about it. :(
|
|
|
matbusby-fw
reviewed
Nov 12, 2024
services/common/src/components/projectSummary/ProjectSummaryFormComponents.spec.tsx
Show resolved
Hide resolved
matbusby-fw
approved these changes
Nov 12, 2024
asinn134
approved these changes
Nov 12, 2024
simensma-fresh
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6129
Why are you making this change? Provide a short explanation and/or screenshots