Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6244] Switched to use gunicorn for Core API to improve performance and ease debugging of 504s #3300

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

simensma-fresh
Copy link
Collaborator

Objective

MDS-6244

Running the Core API app in production with the flask cli is discouraged as it's not meant to be a production-ready tool. Switched to using gunicorn to enable

  • better handling of parallel requests
  • better visibility into what happens when a request times out, as it supports printing a stack trace when that happens

Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Jsyro
Copy link
Collaborator

Jsyro commented Nov 8, 2024

This is long overdue.

Does running gunicorn locally still support hotreloading? or should gunicorn only be for Openshift deployments?

Copy link
Collaborator

@matbusby-fw matbusby-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 🦄

@simensma-fresh
Copy link
Collaborator Author

@Jsyro Gunicorn does support hot-reloading for local development, but haven't had a chance to really test it out yet. So sticking with the flask cli still for that

@simensma-fresh simensma-fresh merged commit fffc9aa into develop Nov 8, 2024
10 of 11 checks passed
@simensma-fresh simensma-fresh deleted the MDS-6244_gunicorn branch November 8, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants