Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] - Update to match Orgbook Publisher Changes #3312

Merged
merged 64 commits into from
Nov 21, 2024
Merged

[FIX] - Update to match Orgbook Publisher Changes #3312

merged 64 commits into from
Nov 21, 2024

Conversation

Jsyro
Copy link
Collaborator

@Jsyro Jsyro commented Nov 21, 2024 •
edited
Loading

Couple minor housekeeping items.

current_app.logger pipes to the core-api-celery pod, so we don't need task logger.
update sql query to identify permittees based on start/end date and issue_date.
orgbook publisher publish endpoint updating, changes here to match
oauth on the publisher.

Jsyro added 30 commits November 6, 2024 13:22
@Jsyro
data typing issues and clean up
03e7aa8
@Jsyro
better logging
962f5e9
@Jsyro
better logging of errors
1af241d
@Jsyro
list of tuples
66e22c4
@Jsyro
add celery decorator
4537f18
@Jsyro
rename var to match envvar
fb883b5
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
6f49d48
@Jsyro
credential per mine_party_appt produces duplicates.
687e03e
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
6cd313b
@Jsyro
wrong class
be179c2
@Jsyro
don't invoke if being used by celery
2652d0f
@Jsyro
query must excluded deleted permit_amendments
7ccd3c0
@Jsyro
add check if cred not created
6ce7067
@Jsyro
improve logging of problem states
a6e44a3
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
a95574b
@Jsyro
make date a date, formatting
4ae3465
@Jsyro
revered received date, update issue_Date validator
9e89270
@Jsyro
all datetimes, never dates
6758491
@Jsyro
typo
f68c378
@Jsyro
names are important
5f23ae3
@Jsyro
only use datetime objects, no date objects
6f05801
@Jsyro
better typing
410ddcc 
ensure factory is producing a datetime and not a date
@Jsyro
ensure second is non-zero for datetime
28b35f7
@Jsyro
oops
27fff76
@Jsyro
brackets matter
2a4a118
@Jsyro
what is happening?
9bd7762
@Jsyro
scoping
7b901f2
@Jsyro
factories making dates, should be datetimes.
8546322 
i have no idea anymore
@Jsyro
idk why that today generator suck
46aeab5
@Jsyro
pass callable
c7e04f0
Jsyro added 15 commits November 15, 2024 09:33
@Jsyro
type checking would have caught this.
10886e1
@Jsyro
enable basic type checking in vscode.
73ddff5 
slow on startup with MDS being large. it might be indexing package files from other language
@Jsyro
operator change
23b5c12
@Jsyro
typing model values
08351e1
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
62882dc
@Jsyro
use a 'forward reference'
1301a37
@Jsyro
current app logger pipe to the celery manager.
cea5568 
don't relate to permitee appointments that are out of date range.
@Jsyro
use authorization end date if set
cb345cb
@Jsyro
remove valid until date, manage with 'refresh' status.
f7d15f2 
exclude exploration permits
@Jsyro
remove enumerate
3638832
@Jsyro
Merge branch 'develop' into feature/issue-to-orgbook-w-publisher
534d63d
@Jsyro
remove old coments
3b0cd6d
@Jsyro
update query.
d112eb5
@Jsyro
new endpoint shape on orgbook publisher
280f6b0
@Jsyro
new env var, new service file, oauth and endpoints
fcf8515
@Jsyro Jsyro requested a review from simensma-fresh November 21, 2024 18:38
@Jsyro Jsyro marked this pull request as ready for review November 21, 2024 18:38
@Jsyro Jsyro requested review from matbusby-fw and taraepp November 21, 2024 18:39
@Jsyro Jsyro added 🌶 Enhancement This is a new feature or request. 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback. 💾 Backend This pull request includes backend changes. 💊 Fix Fixes something that isn't working :) labels Nov 21, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-api'

Failed conditions
34.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@Jsyro Jsyro changed the title [FIX] - Update to match Orgbook Publisher [FIX] - Update to match Orgbook Publisher Changes Nov 21, 2024
@Jsyro Jsyro merged commit dd35fa6 into develop Nov 21, 2024
13 of 14 checks passed
@Jsyro Jsyro deleted the feature/issue-to-orgbook-w-publisher branch November 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matbusby-fw matbusby-fw matbusby-fw approved these changes

@simensma-fresh simensma-fresh simensma-fresh approved these changes

@taraepp taraepp Awaiting requested review from taraepp

Assignees
No one assigned
Labels
💾 Backend This pull request includes backend changes. 🌶 Enhancement This is a new feature or request. 💊 Fix Fixes something that isn't working :) 👍 Ready for review Pull request has been double checked by the author and is ready for comments and feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jsyro @simensma-fresh @matbusby-fw