[MDS-6263] Adjustments around Assigned status not behaving as aspected #3334
Conversation
asinn134
requested review from
simensma-fresh,
matbusby-fw,
taraepp and
sggerard
| status_code = "SUB"; | ||
| } | ||
| } else if (!newActiveTab && status_code === "DFT") { | ||
| status_code = "SUB"; |
There was a problem hiding this comment.
Noticed a sonarcloud issue- just some unused stuff that wants to be removed (isCore wants to be removed, and then probably related imports like the SystemFlagEnum and the selector)
There was a problem hiding this comment.
This should be removed now.
| msDisabledStatuses: ["SUB", "ASG", "UNR", "WDN", "OHD", "COM"], | ||
| msEnabledStatuses: ["DFT", "CHR"], | ||
| msDisabledStatuses: ["SUB", "UNR", "WDN", "OHD", "COM"], | ||
| msEnabledStatuses: ["DFT", "CHR", "ASG"], |
There was a problem hiding this comment.
I do find it confusing that Assigned was added to enabled- like, generally they're still not supposed to be able to edit when it's in Assigned status, right? Is the status even assigned when there's no project lead assigned?
There was a problem hiding this comment.
Hmm, so is the flow that's causing issues basically:
- an MS/CORE user makes a draft project summary
- they assign a project lead
- the project gets put in Assigned status even though it's not submitted
I guess it's pretty wacky! I'm thinking that for the tests though, maybe pass a parameter to indicate that it has been submitted so that we know what to expect generally, and then add another test for the special case where it's assigned but not submitted?
There was a problem hiding this comment.
I reverted the change to the arrays, and a new test has been added now.
|
|
| @@ -18,6 +18,12 @@ describe("Major Projects", () => { | |||
| it("should upload and download a document successfully", () => { | |||
| const fileName = "dummy.pdf"; | |||
|
|
|||
| cy.get('body').then((element) => { | |||
There was a problem hiding this comment.
Depending on the status of the project summary, clicking the button for project description can bring us to the project description tab or the actual project description form page. Just have to include this to make sure we click the View Project Description Details button if we do get sent to the Project Description tab.
|
|
asinn134
deleted the
mds-6263-assigned-status-not-behaving-as-aspected
branch
Objective
MDS-6263
Changed unassigning project lead to not send blank activity for Core and Minespace
Changed assigning project lead to not send notifications for Minespace
Added new text provided in mockup
Adjusted Minespace fields to be editable when a project summary that hasn't been submitted yet has an assigned project lead
Adjusted Core's project management to be able to save a new status and also make an adjustment to the project lead input without the status being forced to be "Submit" or "Assigned"
Adjusted declaration section's submission in Core to change status to "Submit" when a draft project summary is completed