Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6294] - User management #3341

Merged
merged 14 commits into from
Dec 13, 2024
Merged

[MDS-6294] - User management #3341

merged 14 commits into from
Dec 13, 2024

Conversation

matbusby-fw
Copy link
Collaborator

  • Created a user table that is versioned and auto updated on login (currently only set up in Core).
  • Removed legacy unused user components
  • Created a new userSlice for fetching/updating the new user
  • Added this request to the initial loading state requests that need to resolve before load completes
  • Refactored Home.js to Home.tsx in Core.

Objective

MDS-6294

Removed legacy Redux-based user management in favor of a centralized user mechanism using `userSlice`. Added database and API support for user versioning with history tracking to enable auditability. Updated related frontend components and tests to align with the new structure.
@matbusby-fw matbusby-fw marked this pull request as ready for review December 12, 2024 20:46
Copy link
Collaborator

@simensma-fresh simensma-fresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a couple of backend tests that needs fixing, but otherwise looks good

asinn134
asinn134 previously approved these changes Dec 13, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_core-web'

Failed conditions
76.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

@matbusby-fw matbusby-fw merged commit 3ba16b8 into develop Dec 13, 2024
18 of 19 checks passed
@matbusby-fw matbusby-fw deleted the mds-6294-users branch December 13, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants