[MDS-6207] Show PDF of permit amendment on Permit Conditions page + auto-focus on click #3351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simensma-fresh
requested review from
taraepp,
asinn134,
matbusby-fw and
sggerard
simensma-fresh
added
🌶 Enhancement
taraepp
reviewed
Dec 17, 2024
services/core-web/src/tests/components/mine/Permit/PreviewPermitAmendmentDocument.spec.tsx
Show resolved
Hide resolved
taraepp
reviewed
Dec 17, 2024
|
Other than some TS issues, looks very cool and works well! |
simensma-fresh
force-pushed
the
MDS-6207_Permit-condition-doc-viewer
branch
from
3054ce8 to
b4cd914
Compare
matbusby-fw
reviewed
Dec 18, 2024
matbusby-fw
reviewed
Dec 18, 2024
services/common/src/interfaces/permits/permitCondition.interface.ts
Outdated
Show resolved
Hide resolved
matbusby-fw
requested changes
Dec 18, 2024
|
@matbusby-fw Fixed 👍 |
|
|
|
taraepp
approved these changes
Dec 18, 2024
matbusby-fw
approved these changes
Dec 18, 2024
asinn134
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MDS-6207
With all the data about a permit condition now coming over from the permit service, we now have access to the bounding box of where it came from in the original PDF. This PR adds a side-by-side view of the conditions when you click "Open Permit in Document Viewer", where we also highlight the condition in the original PDF on click. Note: This is behind a feature flag, and just added so we can see how well it works/ if it's worth polishing.