Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS-6027] Edit Permit Condition Category #3357

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

taraepp
Copy link
Collaborator

@taraepp taraepp commented Dec 24, 2024

Objective

  • I was tired of doing boilerplate for input components and inconsistently propagating changes to things like the label so I made a wrapper (when updating RenderGroupedSelect)
  • I thought it was super confusing for conditions to sometimes appear in the middle of a section because the display order didn't change so I made it go to the bottom instead.
  • it was weirdly difficult to get the form to not show "N/A" for all fields when the category changed after saving, so did the hacky change with the form name (the other approach that technically worked was dispatching initialize when formValues was undefined but a. that was even more hacky and b. it still flashed "N/A" for a bit)

MDS-6027

Copy link

Quality Gate Passed Quality Gate passed for 'bcgov-sonarcloud_mds_minespace-web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Failed Quality Gate failed for 'bcgov-sonarcloud_mds_common'

Failed conditions
5.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants