MEM-566 ETL - Remove duplicate External Links (MMTI Project Pages) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklise
reviewed
Oct 25, 2017
| var mongodb = require('mongodb'); | ||
| var Promise = require('promise'); | ||
| var _ = require('lodash'); | ||
| var uniqueBy = require('./utils').uniqueBy; |
There was a problem hiding this comment.
While correct, is not necessary due to the require of lodash. Lodash has a method _.uniqBy that achieves the same result as the code in the utils file.
| console.log(': found ' + originalLinkCount + ' external links'); | ||
|
|
||
| // filter out duplicate links | ||
| var links = uniqueBy(mmtiProject.externalLinks, 'link'); |
There was a problem hiding this comment.
As noted above, you can replace this with lodash prototype _.uniqBy
* Cleanup `externalLinks` in Project model * Require Lodash v4.17.4 (for _.uniqBy)
asanchezr
force-pushed
the
MEM-566-duplicate-links-etl
branch
from
063840f to
187f0da
Compare
|
@marklise I've updated the PR. Please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.