Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EM-23] Folder renaming operation allows for duplicate names (fix) #193

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

mjfortier
Copy link

@mjfortier mjfortier commented Jan 16, 2018

documents.manager.rename.directive.js:

  • added variable "repeat" set initially to false
  • in 'self.ok', iterates through folders in current directory to check for repeat names
  • if duplicate is found, "repeat" set to true, AlertService error thrown
  • name changes only if "repeat" is still false

documents.manager.directive.js:

  • added variable "repeat" set initially to false
  • iterates through all folders being moved, and compares them to all folders in destination directory (nested 'forEach' statement)
  • if a match is found, "repeat" set to true, AlertService error thrown
  • if "repeat" is true, no folders are moved. otherwise, all folders are moved

@rpyyj rpyyj merged commit c769a09 into bcgov:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants