Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable next button while checking locations error #469

Merged

Conversation

chloe-yuu
Copy link
Contributor

@chloe-yuu chloe-yuu commented Dec 2, 2024

On the retailer site, when users upload new locations using the CSV method, there's a defect on the "Confirm Locations" page where the "Next" button remains enabled while the application performs validation checks on the uploaded locations. This allows users to bypass the checks and insert invalid data into the database.

The proposed change addresses this issue by adding a loading icon and disabling the "Next" button during the validation process.

Copy link
Contributor

@tristancusiCGI tristancusiCGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloe-yuu chloe-yuu merged commit 233d824 into dev-env Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants