Skip to content

Commit

Permalink
Addressed code review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
weskubo-cgi committed May 24, 2022
1 parent 5efacf0 commit 08fee05
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion frontend/src/components/ui/YesNoRadioButtonGroup.vue
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<AppRadioButtonGroup :e-model="eModel" :id="id" :label="label" :group="this.YES_NO_RADIO_BUTTON_GROUP" v-model="modelValue">
<template v-slot:tooltip><slot name="tooltip"></slot></template>
<template #tooltip><slot name="tooltip"></slot></template>
</AppRadioButtonGroup>
</template>

Expand Down
10 changes: 4 additions & 6 deletions frontend/src/views/eligibility/CoverageStatusCheck.vue
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<AppRow>
<AppCol class="col3">
<AppInput :e-model="v$.phn" id="phn" label="PHN" tooltip type="text" v-model.trim="phn">
<template v-slot:tooltip>Enter the individual’s 10 digit PHN. PHN is a mandatory field. If you leave it blank or enter invalid characters, an edit error message box will be displayed on the input screen.</template>
<template #tooltip>Enter the individual’s 10 digit PHN. PHN is a mandatory field. If you leave it blank or enter invalid characters, an edit error message box will be displayed on the input screen.</template>
</AppInput>
</AppCol>
</AppRow>
Expand All @@ -25,7 +25,7 @@
<AppRow>
<AppCol class="col3">
<AppDateInput :e-model="v$.dateOfService" id="dateOfService" label="Date Of Service" v-model="dateOfService">
<template v-slot:tooltip>The Date of Service defaults on the screen to today's date. The year (CCYY), month (MM) and day (DD) can be overridden. If you override the date with another date, it cannot be greater than today's date or more than 18 months in the past.</template>
<template #tooltip>The Date of Service defaults on the screen to today's date. The year (CCYY), month (MM) and day (DD) can be overridden. If you override the date with another date, it cannot be greater than today's date or more than 18 months in the past.</template>
</AppDateInput>
</AppCol>
</AppRow>
Expand All @@ -49,9 +49,7 @@
<AppCheckbox id="checkLastEyeExam" label="Check for Last Eye Exam" v-model="checkLastEyeExam" />
</div>
</AppCol>
<AppCol>

</AppCol>
<AppCol> </AppCol>
</AppRow>
<AppRow>
<AppButton :submitting="searching" mode="primary" type="submit">Submit</AppButton>
Expand Down Expand Up @@ -82,7 +80,7 @@
</AppCol>
<AppCol class="col3">
<AppOutput label="Eligible on Date of Service?" :value="eligibleOnDateOfService">
<template v-slot:tooltip
<template #tooltip
><p>If the response is "YES", the person is eligible to have their claim for that date of service paid by MSP.</p>
<p>
If the response is "No", the screen will return additional information about why the coverage was terminated and instructions that should be provided to the individual If the individual is subject to alternate billing (RCMP or Armed Forces), this information will also be displayed
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/views/groupmember/AddDependent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</AppCol>
<AppCol class="col4">
<AppDateInput :e-model="v$.coverageEffectiveDate" id="coverageEffectiveDate" label="Coverage Effective Date" monthPicker inputDateFormat="yyyyMM" placeholder="YYYYMM" v-model="coverageEffectiveDate">
<template v-slot:tooltip>Day always defaults to 1st of month</template>
<template #tooltip>Day always defaults to 1st of month</template>
</AppDateInput>
</AppCol>
</AppRow>
Expand All @@ -27,7 +27,7 @@
<AppRow>
<AppCol class="col6">
<YesNoRadioButtonGroup :e-model="v$.isStudent" id="isStudent" label="Is this Dependent attending a Canadian Educational Institution?" v-model="isStudent">
<template v-slot:tooltip> Click either Yes or No </template>
<template #tooltip> Click either Yes or No </template>
</YesNoRadioButtonGroup>
</AppCol>
</AppRow>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/groupmember/AddGroupMember.vue
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</AppCol>
<AppCol class="col3">
<AppDateInput :e-model="v$.coverageEffectiveDate" id="coverageEffectiveDate" label="Coverage Effective Date" monthPicker inputDateFormat="yyyy-MM" placeholder="YYYY-MM" v-model="coverageEffectiveDate">
<template v-slot:tooltip>Date always defaults to first day of the month</template>
<template #tooltip>Date always defaults to first day of the month</template>
</AppDateInput>
</AppCol>
</AppRow>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/groupmember/CancelDependent.vue
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<AppRow>
<AppCol class="col3">
<AppDateInput :e-model="v$.cancelDate" id="cancelDate" label="Coverage Cancel Date" monthPicker inputDateFormat="yyyy-MM" placeholder="YYYY-MM" v-model="cancelDate">
<template v-slot:tooltip> Date always defaults to last day of the month </template>
<template #tooltip> Date always defaults to last day of the month </template>
</AppDateInput>
</AppCol>
</AppRow>
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/groupmember/CancelGroupMember.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<AppRow>
<AppCol class="col3">
<AppDateInput :e-model="v$.cancelDate" id="cancelDate" label="Coverage Cancel Date" monthPicker inputDateFormat="yyyy-MM" placeholder="YYYY-MM" v-model="cancelDate">
<template v-slot:tooltip> Date always defaults to last day of the month </template>
<template #tooltip> Date always defaults to last day of the month </template>
</AppDateInput>
</AppCol>
</AppRow>
Expand Down

0 comments on commit 08fee05

Please sign in to comment.