Updated name validator to allow hypen and whitespace character. (#179)

* Updated name validator to allow hypen and whitespace character. * Updated testcafe --------- Co-authored-by: weskubo-cgi <Wesley.Kubo@gov.bc.ca> Co-authored-by: AnumehaSrivastava05 <anumeha.saran@gmail.com>
bcgov · Feb 16, 2023 · df20fbb · df20fbb
1 parent 9910e97
commit df20fbb
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 2 deletions.
diff --git a/frontend/src/util/validators.js b/frontend/src/util/validators.js
@@ -232,13 +232,13 @@ export function validateSecondName(secondName) {
 }
 
 /**
- * Validate that input is allowed length and that it contains only alphabets
+ * Validate that input is allowed length and that it contains only alphabets, hyphen and whitespace
  */
 function validateAlpha(input, length) {
   if (input.length > length) {
     return true
   }
-  return !/[^a-zA-Z]/.test(input)
+  return !/[^a-z-\sA-Z]/.test(input)
 }
 
 /**

diff --git a/frontend/tests/e2e/tests/enrollment/AddVisaResidentWithoutPHNTest.js b/frontend/tests/e2e/tests/enrollment/AddVisaResidentWithoutPHNTest.js
@@ -175,6 +175,45 @@ test('Check properly filled form passes validation', async (t) => {
     .contains(SUCCESS_MESSAGE)
 })
 
+test('Check hyphen and whitespace are allowed for name fields', async (t) => {
+  await t
+    .typeText(NameSearchPage.surnameInput, 'Test-Test')
+    .typeText(NameSearchPage.firstNameInput, 'Test Test')
+    .typeText(NameSearchPage.dateOfBirthInput, '20001108')
+    .click(NameSearchPage.radioButton)
+    .click(NameSearchPage.submitButton)
+    .wait(1000)
+    .expect(AlertPage.alertBannerText.textContent)
+    .contains(NO_SEARCH_RESULT)
+    // Given the page is filled out correctly
+    .typeText(AddVisaResidentWithoutPHNPage.groupNumberInput, '6337109')
+    .click(AddVisaResidentWithoutPHNPage.immigrationCodeSelect)
+    .click(immigrationCodeOption.withText('Student Authorization'))
+    .typeText(AddVisaResidentWithoutPHNPage.departmentNumberInput, '123456')
+    .typeText(AddVisaResidentWithoutPHNPage.visaIssueDateInput, '20210101')
+    .click(AddVisaResidentWithoutPHNPage.visaExpiryDateInput)
+    .typeText(AddVisaResidentWithoutPHNPage.visaExpiryDateInput, '20221231')
+
+    .typeText(AddVisaResidentWithoutPHNPage.residenceDateInput, '20210101')
+    .typeText(AddVisaResidentWithoutPHNPage.coverageEffectiveDateInput, '20210101')
+    .typeText(AddVisaResidentWithoutPHNPage.coverageCancellationDateInput, '20201231')
+    .typeText(AddVisaResidentWithoutPHNPage.telephoneInput, '7802024022')
+    .typeText(AddVisaResidentWithoutPHNPage.address1Input, 'Test 111 ST')
+    .typeText(AddVisaResidentWithoutPHNPage.cityInput, 'VICTORIA')
+    .click(AddVisaResidentWithoutPHNPage.provinceSelect)
+    .click(provinceOption.withText('British Columbia'))
+    .typeText(AddVisaResidentWithoutPHNPage.postalCodeInput, 'V8V8V8')
+    .click(AddVisaResidentWithoutPHNPage.priorResidenceCodeInput)
+    .click(priorResidenceCodeOption.withText('British Columbia'))
+
+    // When I click the submit button
+    .click(AddVisaResidentWithoutPHNPage.submitButton)
+    .wait(5000)
+    // I expect a success message
+    .expect(AlertPage.alertBannerText.textContent)
+    .contains(SUCCESS_MESSAGE)
+})
+
 test('Check invalid input field characters validation', async (t) => {
   await t
     .typeText(NameSearchPage.surnameInput, 'Test')

diff --git a/frontend/tests/e2e/tests/enrollment/NameSearchTest.js b/frontend/tests/e2e/tests/enrollment/NameSearchTest.js
@@ -79,6 +79,25 @@ test('Check alpha validation for Name', async (t) => {
     .contains(INVALID_SECOND_NAME_MESSAGE)
 })
 
+test('Check hyphen and whitespace are allowed for name fields ', async (t) => {
+  await t
+    // Given I have a form filled out with data
+    .typeText(NameSearchPage.surnameInput, 'Test-surname')
+    .typeText(NameSearchPage.firstNameInput, 'Test firstname')
+    .typeText(NameSearchPage.secondNameInput, 'Test secondname')
+    .typeText(NameSearchPage.dateOfBirthInput, '20211108')
+    .click(NameSearchPage.radioButton)
+    // When I click the submit button
+    .click(NameSearchPage.submitButton)
+    .wait(5000)
+    // I expect the warning message to display
+    .expect(AlertPage.alertBannerText.textContent)
+    .contains(MAX_RESULTS_MESSAGE)
+    // And the Create New PHN BUtton to be available
+    .expect(NameSearchPage.createNewPHNButton.exists)
+    .ok()
+})
+
 test('Check length validation for Name', async (t) => {
   await t
     // Given I have a form filled out with data