Addressed QA feedback #119
Conversation
Added help tooltip Corrected date format Added security
| @@ -173,25 +177,34 @@ private List<PatientRegisterModel> convertPatientRegistration(List<PatientRegist | |||
|
|
|||
| } | |||
|
|
|||
| private String formatDate(Date date) { | |||
| LocalDate localDate = Instant.ofEpochMilli(date.getTime()).atZone(ZoneId.systemDefault()).toLocalDate(); | |||
There was a problem hiding this comment.
There is a method below that does this so could be reused.
| @@ -173,25 +177,34 @@ private List<PatientRegisterModel> convertPatientRegistration(List<PatientRegist | |||
|
|
|||
| } | |||
|
|
|||
| private String formatDate(Date date) { | |||
| LocalDate localDate = Instant.ofEpochMilli(date.getTime()).atZone(ZoneId.systemDefault()).toLocalDate(); | |||
| DateTimeFormatter formatters = DateTimeFormatter.ofPattern(DATE_FORMAT); | |||
There was a problem hiding this comment.
No benefit to declaring and returning on separate lines, could just use:
return localDate.format(DateTimeFormatter.ofPattern(DATE_FORMAT));
There would be some benefit to decaling the formatter statically.
private static final DateTimeFormatter DATE_TIME_FORMATTER_yyyyMMdd = DateTimeFormatter.ofPattern(DATE_FORMAT);
then reusing it
return localDate.format(DATE_TIME_FORMATTER_yyyyMMdd);
Note, always use full name to avoid confusion between objects.
| personDetailsResponse.setDateOfBirth(birthDate); | ||
|
|
There was a problem hiding this comment.
Can remove blank line for better grouping of code
| @@ -176,7 +204,6 @@ export default { | |||
| }, | |||
| resetForm() { | |||
| this.phn = '' | |||
| this.payee = '' | |||
There was a problem hiding this comment.
Why is this removed, payee field should be reset also?
There was a problem hiding this comment.
It will be a read only field once https://dev.azure.com/cgi-vic-hlth/HNWeb/_workitems/edit/7102 is done.
Added help tooltip
Corrected date format
Added security