7836 improve address input for r38 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prit-cgi
requested review from
AnumehaSrivastava05,
weskubo-cgi and
daveb-hni
frontend/src/util/validators.js
Outdated
| @@ -186,7 +185,7 @@ function validateSpecialCharactersForAddress(input, length) { | |||
| * Used to validate that Mailing Address line 1 must be completed if any other Mailing Address(Line 2, Line 3, Line 4, PostalCode) is complete | |||
| */ | |||
| export function validateMailingAddress() { | |||
| return this.mailingAddress.addressLine2 !== '' || this.mailingAddress.addressLine3 !== '' || this.mailingAddress.addressLine4 !== '' || this.mailingAddress.postalCode !== '' | |||
| return this.mailingAddress.addressLine2 !== '' || this.mailingAddress.city !== '' || this.mailingAddress.province !== '' || this.mailingAddress.postalCode !== '' | |||
There was a problem hiding this comment.
addressline3 and addressline4 still being used by other transactions. Create a new function for now
Comment on lines
93
to
97
| <h2 class="result-text">Transaction Completed for:</h2> | ||
| <div> | ||
| <div><span class="result-text"> Group Number: </span>{{ groupNumber }}</div> | ||
| <div><span class="result-text">PHN: </span>{{ result?.phn }}</div> | ||
| </div> |
There was a problem hiding this comment.
Refer UpdateNumberAndDept.vue for consistency
AnumehaSrivastava05
suggested changes
Dec 5, 2022
Comment on lines
16
to
17
| this.mailingAddress3Input = Selector('#mailingCity') | ||
| this.mailingAddress4Input = Selector('#mailingProvince') |
There was a problem hiding this comment.
Change it to this.mailingAddressCityInput & this.mailingAddressProvinceInput
Comment on lines
11
to
12
| this.address3Input = Selector('#city') | ||
| this.address4Input = Selector('#province') |
There was a problem hiding this comment.
Change it to this.homeAddressCityInput & this.homeAddressProvinceInput
Comment on lines
9
to
10
| const INVALID_ADDRESS_LINE3_MESSAGE = 'City is invalid' | ||
| const INVALID_ADDRESS_LINE4_MESSAGE = 'Province is invalid' |
There was a problem hiding this comment.
It should INVALID_CITY_MESSAGE & INVALID_PROVINCE_MESSAGE
AnumehaSrivastava05
approved these changes
Dec 6, 2022
weskubo-cgi
pushed a commit
that referenced
this pull request
Dec 9, 2022
This reverts commit e88ef79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.