-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5088 r36 cancel group member dependent #40
Merged
AnumehaSrivastava05
merged 12 commits into
main
from
5088_R36_Cancel_Group_Member_Dependent
Feb 2, 2022
Merged
5088 r36 cancel group member dependent #40
AnumehaSrivastava05
merged 12 commits into
main
from
5088_R36_Cancel_Group_Member_Dependent
Feb 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added UI component , routing, UI validation 2. Added testcafe
1. Added route 2. Added relationship field and validation 3 Updated testcafe
1. Added request and response 2. Added converter 3. Added RPBSPWP0 and WP0 message module 4. Added controller method 5. Added service method 6. Added unit test
1. Updated unit test 2. Corrected button text
1. Code cleanup, fields, comments and method name correction
weskubo-cgi
requested changes
Feb 1, 2022
backend/src/main/java/ca/bc/gov/hlth/hnweb/converter/rapid/RPBSPWP0Converter.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/hlth/hnweb/converter/rapid/RPBSPWP0Converter.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/hlth/hnweb/model/rapid/WP0.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/hlth/hnweb/model/rapid/WP0.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/hlth/hnweb/model/rapid/WP0.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/hlth/hnweb/controller/GroupMemberController.java
Outdated
Show resolved
Hide resolved
1. Refactored/renamed class, method, variable name 2. Removed extra line 3. Corrected comments
weskubo-cgi
approved these changes
Feb 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.