5264 r37 get employee's contract address #59
Conversation
Implement all outstanding permissions
| * | ||
| * Also used by R37 as the results required for R37 are a subset of those returned for Contract Inquiry so it can return the same result. This | ||
| * does not break overall security as currently all roles with permissions for R37(Get Group Member's Contract Address) also have permission | ||
| * for R40(Contract Inquiry). | ||
| * | ||
| * @param contractInquireRequest |
There was a problem hiding this comment.
Not related to this commit but the name of the param (in javadoc and method) doesn't match it's class. Inquire vs INquiry.
There was a problem hiding this comment.
Updated param name.
| @@ -75,7 +75,11 @@ | |||
|
|
|||
| /** | |||
| * Get MSP Coverage info for a Personal Health Number (PHN) of a group Inquiry | |||
| * Maps to the legacy R40. | |||
| * Maps to the legacy: R40. | |||
There was a problem hiding this comment.
Javadoc formatting is now different between this method and others. Most don't use the colon.
| @@ -17,7 +17,8 @@ | |||
| CANCEL_GROUP_MEMBER("CancelGroupMember"), | |||
| CANCEL_DEPENDENT("CancelDependent"), | |||
| GET_CONTRACT_PERIODS("GetContractPeriods"), | |||
| CONTRACT_INQUIRY("ContractInquiry"), | |||
| CONTRACT_INQUIRY("ContractInquiry"), //R40 | |||
| GET_GROUP_MEMBERS_CONTRACT_ADDRESS("GetGroupMembersContractAddress"), //R37 | |||
There was a problem hiding this comment.
We should just use GET_CONTRACT_ADDRESS(GetContactAddress) which matches the new terminology: GetContractAddress. The list of transactions is available on the Audit Design page.
There was a problem hiding this comment.
Updated enum name & prop
| @@ -46,6 +46,7 @@ | |||
| <div class="dropdown-content"> | |||
| <router-link @click="resetAlert" :class="menuClass($route, 'GetContractPeriods')" :to="{ name: 'GetContractPeriods' }">Get Contract Periods</router-link> | |||
| <router-link @click="resetAlert" :class="menuClass($route, 'ContractInquiry')" :to="{ name: 'ContractInquiry' }">Contract Inquiry</router-link> | |||
| <router-link @click="resetAlert" :class="menuClass($route, 'GetGroupMembersContractAddress')" :to="{ name: 'GetGroupMembersContractAddress' }">Get Group Member's Contract Address</router-link> | |||
There was a problem hiding this comment.
This needs to be secured.
| path: 'getGroupMembersContractAddress', | ||
| name: 'GetGroupMembersContractAddress', | ||
| component: GetGroupMembersContractAddress, | ||
| }, |
There was a problem hiding this comment.
This needs to be secured.
| <tbody> | ||
| <tr> | ||
| <!-- Only the first row should be shown as that will be the searched on Group Member --> | ||
| <GroupMemberContractBeneficiary :beneficiary="result.contractInquiryBeneficiaries[0]" /> |
There was a problem hiding this comment.
I think it would be cleaner to store the single row as data rather than the whole result. Nevermind, I see that other parts of the result are used. How about a computed field then?
There was a problem hiding this comment.
Moved to computed field
| @@ -7,6 +7,7 @@ import SubNavTab from '../../components/template/SubNavTab.vue' | |||
| <TheSubNav> | |||
| <SubNavTab routeName="GetContractPeriods" title="Get Contract Periods" /> | |||
| <SubNavTab routeName="ContractInquiry" title="Contract Inquiry" /> | |||
| <SubNavTab routeName="GetGroupMembersContractAddress" title="Get Group Member's Contract Address" /> | |||
There was a problem hiding this comment.
This needs to be secured.
Added R37 Transaction