6050 enhancements r50a r50c #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added new immigration codes 2. Added new confirmation page 3. Added button
1. Deleted immigration code fpr Diplomat 2. Updated method for button 3. Updated view
daveb-hni
reviewed
Mar 22, 2022
| @@ -10,6 +10,7 @@ | |||
| <AppOutput label="Name" :value="fullName" /> | |||
| </AppCol> | |||
| </AppRow> | |||
| <AppButton @click="goToAddAnotherPermitHolder()" mode="primary" type="button">Add Another Permit Holder</AppButton> | |||
There was a problem hiding this comment.
Method name could be more concise e.g. addAnotherPermitHolder
| @@ -10,6 +10,7 @@ | |||
| <AppOutput label="Name" :value="fullName" /> | |||
| </AppCol> | |||
| </AppRow> | |||
| <AppButton @click="goToAddAnotherPermitHolder()" mode="primary" type="button">Add Another Permit Holder</AppButton> | |||
There was a problem hiding this comment.
Method name could be more concise e.g. addAnotherPermitHolder
| @@ -10,6 +10,7 @@ | |||
| <AppOutput label="Name" :value="fullName" /> | |||
| </AppCol> | |||
| </AppRow> | |||
| <AppButton @click="goToAddAnotherPermitHolder()" mode="primary" type="button">Add Another Permit Holder</AppButton> | |||
There was a problem hiding this comment.
Should the text indicate if the user will add Permit Holder with or without PHN as could navigate to either.
| @@ -10,6 +10,7 @@ | |||
| <AppOutput label="Name" :value="fullName" /> | |||
| </AppCol> | |||
| </AppRow> | |||
| <AppButton @click="goToAddAnotherPermitHolder()" mode="primary" type="button">Add Another Permit Holder</AppButton> | |||
There was a problem hiding this comment.
Should the text indicate if the user will add Permit Holder with or without PHN as could navigate to either.
Added dynamic button name
daveb-hni
requested changes
Mar 22, 2022
| this.$store.commit('alert/dismissAlert') | ||
| this.$router.replace({ query: null }) | ||
| this.$router.push('/coverage/enrollment/addStudyPermitHolderWithoutPHN') | ||
| } else this.$router.go() |
There was a problem hiding this comment.
Note, they were in previous commit.
daveb-hni
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.