Made keycloak client configurable using the Spring security audience value #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weskubo-cgi
requested changes
Mar 28, 2022
Comment on lines
98
to
101
| @Value("${spring.security.oauth2.resourceserver.jwt.audience}") | ||
| public void setKeycloakClientStatic(String keycloakClient){ | ||
| SecurityUtil.KEYCLOAK_CLIENT = keycloakClient; | ||
| }} |
There was a problem hiding this comment.
Do we want to put this code right under the variable declaration? Might be clearer what's happening that way.
There was a problem hiding this comment.
Agreed, moved method up for clarity
weskubo-cgi
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the SecurityUtil to allow the value of the Keycloak client to be configurable in properties. Currently uses the Spring security audience value as they are expected to be the same. Also, this value has to injected to a static variable as it's used in static methods so uses method injection instead of directly on the variable.