6301 logout should logout idp session #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AnumehaSrivastava05
commented
Jun 23, 2022
AnumehaSrivastava05
commented
- Added SiteMinder logout uri
- Added PHSA logout uri
- Set Keycloak redirect uri to SiteMinder logout for full SSO
1. Added uri in env config file 2. Updated logout method. Added code to logout from ldp session
Added SITE_MINDER_LOGOUT_URI Added PHSA_LOGOUT_URI
tschia
previously approved these changes
Jun 24, 2022
tschia
reviewed
Jun 24, 2022
| case 'phsa': | ||
| logouturi = phsaLogoutUri | ||
| default: | ||
| break |
There was a problem hiding this comment.
We should maybe make the default case just logout of Keycloak so
logouturi = redirectUri
tschia
dismissed
their stale review
missed something, comment should be addressed first
1. Added url for default case 2. Corrected variable name( made it camelCase)
tschia
approved these changes
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.