Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18951 Change amalgamation to amalgamationApplication #750

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

kzdev420
Copy link
Collaborator

Issue #: /bcgov/entity#18951

Description of changes:

Amalgamation Object will be like this

filing: {
        header: {
          name: 'amalgamationApplication',   // updated
          accountId: 3040
        },
        business: {
          legalType: 'BC'
        },
        amalgamationApplication: {     // updated
          nameRequest: {
            legalType:  'BC'
          },
          type: 'regular'
        }
      }

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namerequest license (Apache 2.0).

@kzdev420 kzdev420 requested review from jamespaologarcia, eve-git and severinbeauvais and removed request for jamespaologarcia and eve-git December 18, 2023 19:40
@kzdev420 kzdev420 self-assigned this Dec 18, 2023
@kzdev420 kzdev420 requested a review from eve-git December 18, 2023 19:41
@kzdev420 kzdev420 assigned JazzarKarim and unassigned JazzarKarim Dec 18, 2023
@kzdev420 kzdev420 requested a review from JazzarKarim December 18, 2023 19:42
@severinbeauvais
Copy link
Collaborator

Kevin, you need to import the latest shared enums. That's why the build-check has failed.

Next time, please run the build locally (and also the unit tests and linting) before assigning reviewers to the PR.

@severinbeauvais
Copy link
Collaborator

@eve-git @ozamani9gh We would like to merge this PR as soon as possible. Are you able to review this PR? Can we merge it ourselves?

@kzdev420
Copy link
Collaborator Author

/gcbrun

@bcgov bcgov deleted a comment from bcregistry-sre Dec 18, 2023
@bcgov bcgov deleted a comment from kzdev420 Dec 18, 2023
@bcgov bcgov deleted a comment from kzdev420 Dec 18, 2023
@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://namerequest-dev--pr-750-7lf1pe42.web.app

@ozamani9gh ozamani9gh merged commit 7b3b5c1 into bcgov:main Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants