feat: #1145 use cached access for applications list #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ianliuwk1019
commented
Feb 21, 2024
•
ianliuwk1019
commented
- Only do "refreshCachedUserAccess" to update access when user login.
- Refactor on AuthService.ts to migrate user related content to FamLoginUserState.ts
- Quick addition on showing user access levels on ProfileSideBar.
- Read "applicationsUserAdministers" from cached FamLoginUserState for display on ManagePermission page.
- Read "applicationOptions" from cached FamLoginUserState for display on GrantApplicationAdmin page.
- Remove "fetchApplications" from route and from "fetchData", no need anymore.
… on grant admin page.
|
Thanks Ian! Looks great! Just some small comment for simplify and clarification. Also maybe Nick @NickSaglioni if you want to check on this pr, Ian is getting the application options inside the component now instead of preparing it in the router handler, just regarding of your question this morning. Thanks so much! |
|
MCatherine1994
approved these changes
Feb 23, 2024
ianliuwk1019
deleted the
feat/1145-use-cached-access-for-applications-list
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.