Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor backend improvement part2 #860

Merged
merged 19 commits into from
Sep 6, 2023
Merged

fix: minor backend improvement part2 #860

merged 19 commits into from
Sep 6, 2023

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented Sep 1, 2023 •
edited
Loading

Continue refactoring/improvement at backend.
This PR mainly focuses on improvement for router code (router_user_role_assignment.py):

  • Migrate some validations from jwt_validation.py and router_user_role_assignment.py into a
    new file: "router_guards.py".
  • Migrate previous "requester" into schemas.py and add one "target_user" class.
  • Simplify "router_user_role_assignment.py" code with using FastAPI "Depends" (dependency injection): depends on validations to pass before handler is called.
  • Fix tests - reset dependency override back to default so it does not affect other tests.

@ianliuwk1019
WIP some TODO
43e7e7b
@ianliuwk1019
Add authorize_by_application_role fastapi dependency for validation.
722bea3
@ianliuwk1019
Refactor authorize_by_app_id to router dependency
78ce1ca
@ianliuwk1019
Replace authorize_by_app_id with authorize_by_application_role as dep…
8cc7c88 
…endency
@ianliuwk1019
Merge branch 'main' into fix/minor-backend-improvement
2bf05ae
@ianliuwk1019
Remove redundant authorize_by_app_id since authorize_by_application_r…
f82a638 
…ole is in place.
@ianliuwk1019
Refactor Requester class into schemas.py
7215f3e
@ianliuwk1019
Refactor jwt_validation some functions to new router_guards.py
d77bb2f
@ianliuwk1019
Use orm_mode for Requester and conveniently convert it from model usi…
5a54090 
…ng from_orm()
@ianliuwk1019
Further refactor for get_request_role_from_id
2d568fd
@ianliuwk1019
Add comment for Requester and add new TargetUser.
71e7c22
@ianliuwk1019
Create "enforce_self_grant_guard" for router and remove same code fro…
057bcb4 
…m router_user_role_assignment.py router
@ianliuwk1019
Minor fix for tests.
ee4592e
@ianliuwk1019
Minor cleaup and commenting.
4481d5c
@ianliuwk1019 ianliuwk1019 changed the title Fix/minor backend improvement part2 fix: minor backend improvement part2 Sep 1, 2023
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review September 5, 2023 16:22
@ianliuwk1019 ianliuwk1019 merged commit c049bab into main Sep 6, 2023
9 checks passed
@ianliuwk1019 ianliuwk1019 deleted the fix/minor-backend-improvement-part2 branch September 6, 2023 21:52
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCatherine1994 MCatherine1994 MCatherine1994 approved these changes

@basilv basilv Awaiting requested review from basilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianliuwk1019 @MCatherine1994