-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #839 fix browser console error for labels #866
Merged
MCatherine1994
merged 7 commits into
main
from
fix/839-browser-console-error-grant-access-form
Sep 6, 2023
Merged
fix: #839 fix browser console error for labels #866
MCatherine1994
merged 7 commits into
main
from
fix/839-browser-console-error-grant-access-form
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0taFerreira
requested review from
NickSaglioni,
ianliuwk1019 and
MCatherine1994
September 5, 2023 14:49
ianliuwk1019
requested changes
Sep 5, 2023
ianliuwk1019
requested changes
Sep 5, 2023
I don't feel we need these changes.... If we check the primevue component:
I'll try to push some fixes |
…agement into fix/839-browser-console-error-grant-access-form
MCatherine1994
previously approved these changes
Sep 5, 2023
…agement into fix/839-browser-console-error-grant-access-form
ianliuwk1019
approved these changes
Sep 6, 2023
MCatherine1994
deleted the
fix/839-browser-console-error-grant-access-form
branch
September 6, 2023 22:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the ways primevue recommends for labeling it's inputs is to use aria-labelledby with a matching span as label.
exemple:
<span id="rb2">Two</span> <RadioButton aria-labelledby="rb2" />