Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #839 fix browser console error for labels #866

Merged

Conversation

J0taFerreira
Copy link
Contributor

  • fixed console error for labels not having a match id.

One of the ways primevue recommends for labeling it's inputs is to use aria-labelledby with a matching span as label.
exemple:
<span id="rb2">Two</span> <RadioButton aria-labelledby="rb2" />

@ianliuwk1019
Copy link
Collaborator

I seem to see these (not error, but warning) still, seems to be related:
image

image

@MCatherine1994
Copy link
Contributor

MCatherine1994 commented Sep 5, 2023

I don't feel we need these changes....

If we check the primevue component:

I'll try to push some fixes

- fix label for error for input fields
- clean up grant access form element class
refs: #839
@MCatherine1994
Copy link
Contributor

I also did a cleanup and restructure of the elements in the grant access form component. When write the page elements, make sure we use the same pattern for the sections. For example, for this grant access form, each field should share the similar structure. For each field, it will be inside a div element with the classname "row" for margin. And then inside each div, it will be label and whatever form element. It will make our code more clear.

Screen Shot 2023-09-05 at 4 17 48 PM Screen Shot 2023-09-05 at 4 18 25 PM

MCatherine1994
MCatherine1994 previously approved these changes Sep 5, 2023
@MCatherine1994 MCatherine1994 merged commit ab15111 into main Sep 6, 2023
8 checks passed
@MCatherine1994 MCatherine1994 deleted the fix/839-browser-console-error-grant-access-form branch September 6, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants